Breaking: Update fixer-return and prefer-replace-text rules to also apply to suggestion fixer functions
#194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
fixer-return-prefer-replace-text-suggestions
branch
from
df39419 to
4d53d0f
Compare
aladdin-add
reviewed
Sep 27, 2021
| contextIdentifiers.has(parent.parent.parent.parent.parent.parent.callee.object) && | ||
| parent.parent.parent.parent.parent.parent.callee.property.name === 'report' && | ||
| this.getReportInfo(parent.parent.parent.parent.parent.parent.arguments).suggest === parent.parent.parent; | ||
| }, |
There was a problem hiding this comment.
can you add a few tests for it, in tests/lib/utils.js?
bmish
force-pushed
the
fixer-return-prefer-replace-text-suggestions
branch
2 times, most recently
from
2c08674 to
25de00f
Compare
…so apply to suggestion fixer functions
bmish
force-pushed
the
fixer-return-prefer-replace-text-suggestions
branch
from
25de00f to
13f7d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules should apply to both autofix and suggestion fixer functions.
Updating these two rules together since they share the same logic.
Fixes #193
Fixes #190
Part of v4 release (#120).